Public
/
MessageWeave
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(state): assert the dedup TTL floor as an upper bound, not a window 

A remote TLS readback arrives after most of the 1s floor has been consumed,
so the +/-500 ms window could never be met (PTTL -2 / 269 / 118 ms across
three runs). PTTL -1 is what actually signals the regression this assertion
guards against -- EX silently dropped, key lives forever -- and a live value
can only be counting down, so bound it from above.

SET ... NX EX 1 itself is unchanged; the expired (-2) outcome is what proved
it took effect.
This commit is contained in:
anonsaber 2026-09-30 14:51:58 +08:00
parent e9c979bd1a
commit 5c77fab597
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/state.rs
View File

@ -1810,8 +1810,14 @@ mod real_redis_ttl_tests {
.expect("REDIS_TEST_URL must be reachable");
let run = unique();
// Zero is floored to 1 second by `.max(1)`: Redis rejects an empty or
// zero EX with "invalid expire time in SET command".
// Zero is floored to 1 second by `.max(1)`: Redis rejects a zero EX
// with "invalid expire time in SET command", so the unwrap below
// already proves the floor ran. PTTL rules out the other variant, where
// the EX is silently dropped and the key has no expiry at all (-1). A
// live readback can only be counting *down* from the 1s floor, and a
// whole second is usually gone by the time this reaches a remote TLS
// instance, so the floor is asserted as an upper bound rather than as
// an absolute value.
let zero = format!("ttlcheck:dedup:{run}:zero");
assert!(state.claim_dedup(&zero, 0).await.unwrap());
let mut conn = state.connection.clone();
@ -1820,7 +1826,14 @@ mod real_redis_ttl_tests {
.query_async(&mut conn)
.await
.unwrap();
assert_within(pttl, 1, 500);
assert!(
pttl != -1,
"EX 0 was not normalized to EX 1: the dedup key was written with no expiry"
);
assert!(
pttl == -2 || pttl <= 1_000 + 2_000,
"expected the remaining TTL to be within the 1s floor, got {pttl} ms"
);
delete_key(state.connection.clone(), &zero).await.unwrap();
// A normal request is honoured to the second.